Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slim] Migration to PHP7 #1263

Merged
merged 4 commits into from
Oct 26, 2018
Merged

[Slim] Migration to PHP7 #1263

merged 4 commits into from
Oct 26, 2018

Conversation

ybelenko
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Migration to PHP7 requested in issue #1246

I didn't add typehints to functions because we have expressive phpdoc comments.

Output from executed tests under openapi-generator/samples/server/petstore/php-slim:

$ composer test
> phpunit --testsuite Apis
PHPUnit 7.4.0 by Sebastian Bergmann and contributors.

..................................                                34 / 34 (100%)

Time: 498 ms, Memory: 4.00MB

OK (34 tests, 0 assertions)
> phpunit --testsuite Models
PHPUnit 7.4.0 by Sebastian Bergmann and contributors.

...............................................................  63 / 133 ( 47%)
............................................................... 126 / 133 ( 94%)
.......                                                         133 / 133 (100%)

Time: 2.44 seconds, Memory: 6.00MB

OK (133 tests, 0 assertions)
$ composer run phplint
> phplint ./ --exclude=vendor
phplint 1.0.2 by overtrue and contributors.

No config file loaded.

.......................................................................................

Time: 4 secs    Memory: 2.0 MiB Cache: No

OK! (Files: 87, Success: 87)
$ composer run phpcs
> phpcs ./ --ignore=vendor --warning-severity=0 --standard=PSR12

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh

@ybelenko ybelenko added this to the 4.0.0 milestone Oct 17, 2018
wing328
wing328 approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 30062af into OpenAPITools:4.0.x Oct 26, 2018
@ybelenko ybelenko deleted the slim_php7 branch November 17, 2018 05:05
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
@ybelenko @wing328
[Slim] Migration to PHP7 (OpenAPITools#1263)
1eaac13 
* [Slim] Add PHP 7.0 to requirements

* [Slim] Migrate to PHPUnit 6

* [Slim] Update user guide

* [Slim] Refresh samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wing328 wing328 wing328 approved these changes

Assignees
No one assigned
Labels
Breaking change (without fallback) Enhancement: Compatibility Server: PHP
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ybelenko @wing328